From 877bb9448f49b7de9e060692ca1c01b4f552bb2b Mon Sep 17 00:00:00 2001
From: Greyhoof <132987288+greyhoof@users.noreply.github.com>
Date: Tue, 10 Oct 2023 10:24:17 +0200
Subject: [PATCH] x Potential fix for selecting executables as external browser
on Mac and Linux
---
electron/main.ts | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/electron/main.ts b/electron/main.ts
index 48ff691..7b613ef 100644
--- a/electron/main.ts
+++ b/electron/main.ts
@@ -744,11 +744,24 @@ function onReady(): void {
electron.ipcMain.handle('browser-option-browse', async () => {
log.debug('settings.browserOption.browse');
console.log('settings.browserOption.browse', JSON.stringify(settings));
+
+ const os = require('os');
+ let filters;
+ if(os.platform() === "win32") {
+ filters = [{ name: 'Executables', extensions: ['exe'] }];
+ } else if (os.platform() === "darwin") {
+ filters = [{ name: 'Executables', extensions: ['app'] }];
+ } else {
+ // linux and anything else that might be supported
+ // no specific extension for executables
+ filters = [{ name: 'Executables', extensions: ['*'] }];
+ }
+
const dir = electron.dialog.showOpenDialogSync(
{
defaultPath: settings.browserPath,
properties: ['openFile'],
- filters: [{ name: 'Executables', extensions: ['exe'] }]
+ filters: filters
});
if(dir !== undefined) {
return dir[0];