From cdce88484443acdbf4b5f1660e9bd945cc788c67 Mon Sep 17 00:00:00 2001
From: Greyhoof <132987288+greyhoof@users.noreply.github.com>
Date: Tue, 10 Oct 2023 10:07:29 +0200
Subject: [PATCH] x Fixed openURLExternally() encoding URLs that were already
 encoded

---
 electron/main.ts | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/electron/main.ts b/electron/main.ts
index 253ca39..48ff691 100644
--- a/electron/main.ts
+++ b/electron/main.ts
@@ -177,8 +177,16 @@ function openURLExternally(linkUrl: string): void {
     if(settings.browserPath !== '' &&
         fs.existsSync(settings.browserPath) &&
         fs.lstatSync(settings.browserPath).isFile()) {
-        // encode URL so if it contains spaces, it remains a single argument for the browser
-        linkUrl = encodeURI(linkUrl);
+
+        // check if URL is already encoded
+        // (this should work almost all the time, but there might be edge-cases with very unusual URLs)
+        let isEncoded = (linkUrl !== decodeURI(linkUrl));
+        // only encode URL if it isn't encoded yet
+        if(!isEncoded) {
+            // encode URL so if it contains spaces, it remains a single argument for the browser
+            linkUrl = encodeURI(linkUrl);
+        }
+
 
         if(!settings.browserArgs.includes('%s')) {
             // append %s to params if it is not already there